Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3d9] Shogun 2 crash on battle exit #2703

Closed
Blisto91 opened this issue Jul 2, 2022 · 2 comments
Closed

[d3d9] Shogun 2 crash on battle exit #2703

Blisto91 opened this issue Jul 2, 2022 · 2 comments
Assignees
Labels

Comments

@Blisto91
Copy link
Contributor

Blisto91 commented Jul 2, 2022

In dx9 mode shogun 2 can or will crash on battle exit if Terrain Quality is set to high.
It does not matter if all other setting are off or low, just that Terrain Quality is set to High. Doesn't happen with the setting set to low.
First discovered in #2591 but i don't think it is directly related to that issue.

Way to reproduce

  1. Start shogun 2 in dx9 mode
  2. Make sure Terrain Quality is set to High
  3. Go to historical battles and start Toba Fushimi
  4. Once in the battle press escape and Concede Defeat
  5. Observe crash before you get back to menu

If it doesn't crash the first time then try again.
Doesn't happen in wined3d

Software information

Shogun 2 Terrain Quality High

System information

  • GPU: R9 380
  • Driver: 1 week old mesa-git
  • Wine version: Proton 7.0-3
  • DXVK version: Latest unmap branch (doesn't help). Also happens on 1.10.1

Apitrace file(s)

Apitrace pending

Log files

Shogun2_d3d9.log
Shogun2_d3d11.log
Shogun2_dxgi.log

Errors can also be seen at the end of the proton log
steam-34330.log

@K0bin
Copy link
Collaborator

K0bin commented Feb 4, 2023

This is caused by running out of address space.

Curiously, it's not buffers or constants that cause it (partially because we are already doing a bunch of tricks to avoid that) but StateBlocks instead.

image

warn: state blocks: 8314 memory of one: 190616 memory of state: 188792 total (MB): 1511

@K0bin K0bin added the d3d9 label Feb 4, 2023
@K0bin K0bin self-assigned this Feb 4, 2023
@K0bin K0bin closed this as completed Mar 8, 2023
@K0bin
Copy link
Collaborator

K0bin commented Mar 10, 2023

Fixed by #3248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants