Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Jade Empire: Special Edition (7110) videos play incorrectly #3182

Closed
alasky17 opened this issue Jan 11, 2023 · 6 comments · Fixed by #3342
Closed

[Regression] Jade Empire: Special Edition (7110) videos play incorrectly #3182

alasky17 opened this issue Jan 11, 2023 · 6 comments · Fixed by #3342

Comments

@alasky17
Copy link

Jade Empire: Special Edition no longer plays videos correctly. This can be easily seen by just launching the game and looking at the videos that play before the main menu. See screenshots posted by @legluondunet on the github issue where this was first reported: ValveSoftware/Proton#2112 (comment) jade-good-video
jade-bad-video

Software information

Jade Empire: Special Edition (7110)

System information

  • GPU: AMD Radeon RTX 570 Series
  • Driver: 22.3.2 Vulkan 1.3.230
  • Wine version: Regression between Proton 5.0-10 and Proton 5.13-1
  • DXVK version: Regression between [2e37825] [meta] Release 1.7 (good) and 4439e8a [dxvk_config] Add new dxvk_config library (bad)
    My builds weren't completing properly, so I was unable to narrow it down further.

Apitrace file(s)

  • Unfortunately I was unable to get an apitrace, even with the new technique :/

Log files

@Blisto91
Copy link
Contributor

Thanks for the report.
I can try to see if i am able to get a apitrace of the issue here later.

@Blisto91
Copy link
Contributor

Blisto91 commented Jan 12, 2023

I have bisected this to be either
2bf9f29
or
9fe1b9d

I can't test the first one directly as the game will crash when the videos are supposed to start. The second one is the commit right after and have the broken videos

@Blisto91
Copy link
Contributor

Managed to trace the game but the issue just gets baked into it so i'm uploading a working made with 1.7 and a broken made with 1.7.1.

https://mega.nz/file/V9JxALQD#CsgYjEhTN5S-NuUnGYhgrVZNnmJEcUugXowCvvkdPPQ

@K0bin
Copy link
Collaborator

K0bin commented Jan 12, 2023

The issue here seems to be how the data for the format converter is packed. The format is YUY2.

@Blisto91
Copy link
Contributor

This appears to work again when changing

VK_FORMAT_B8G8R8A8_UNORM,

to VK_FORMAT_G8B8G8R8_422_UNORM, but i don't know if that is correct so just posting it here on the issue so it doesn't get lost before it's looked at.
Same for #3189

@legluondunet
Copy link

just tested with Proton experimental, the cinematics played nicely, bravo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants