Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space and enter keys dont work correctly on dgrid sort #1417

Closed
rushil-patel opened this issue Apr 5, 2018 · 1 comment
Closed

Space and enter keys dont work correctly on dgrid sort #1417

rushil-patel opened this issue Apr 5, 2018 · 1 comment
Labels

Comments

@rushil-patel
Copy link

Similar to #731 but in this case I'm not using the selector plugin-in. I'm listening for the "dgrid-sort" event which seems to be called twice when "enter" or "space is clicked. It looks like "click" and "keydown" events are fired when "enter" or "space" key is pressed.

This is my listener that appears to be called twice:
grid.on("dgrid-sort", function (evt) {.....}

I've traced "dgrid-sort" emission back to : https://github.com/SitePen/dgrid/blob/master/Grid.js#L279

I'm not sure why both "click" and "keydown" events get fired on pressing enter or space keys. But the the sort Listener catches and emits "dgrid-sort" twice for enter and space key presses.

@dylans dylans added the bug label Apr 10, 2018
@rushil-patel
Copy link
Author

Closed, resolved by updating to the latest version. Can't repro anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants