Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnDemandList does not refresh on store.setData #1448

Open
msssk opened this issue Jan 16, 2020 · 2 comments
Open

OnDemandList does not refresh on store.setData #1448

msssk opened this issue Jan 16, 2020 · 2 comments

Comments

@msssk
Copy link
Contributor

msssk commented Jan 16, 2020

This issue is from dojo/dojo1-dstore#201.

A declare([ Memory, Trackable]) object does not automatically update the grid.

When dstore/Memory#setData is called on a declare([ Memory, Trackable]) object, the grid is not updated. In order to update the grid a reference to the grid must be available (grid#refresh()) or the dojo/store/Memory#putSync method must be used.

In comparison, dojo/store/Memory#setData does update the associated dijit/form/Select object.

Should dstore/Memory#setData be made to update its associated grids?

@msssk
Copy link
Contributor Author

msssk commented Jan 16, 2020

This certainly seems to make sense on the surface. However, dgrid has always behaved this way, even the 0.3 releases that used Dojo object stores, so changing behavior at this point would be a breaking change. There may be other considerations as well.

@fkranenburg
Copy link

I had the same problem and solution, maybe add extra flag property to auto update grid when data is changed so it won't be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants