Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leaks in Grid.js ? #393

Closed
sgodden opened this issue Jan 21, 2013 · 0 comments
Closed

Memory leaks in Grid.js ? #393

sgodden opened this issue Jan 21, 2013 · 0 comments

Comments

@sgodden
Copy link

sgodden commented Jan 21, 2013

I may be revealing my ignorance here, but doesn't code like this cause memory leaks when we destroy and re-create grids repeatedly?

listen(row, "click,keydown", function(event){
                // respond to click, space keypress, or enter keypress
                if(event.type == "click" || event.keyCode == 32 /* space bar */ || (!has("opera") && event.keyCode == 13) /* enter */){
                    var target = event.target,

The handler returned from dojo/on is not being stored anywhere, to be removed on destruction of the component.

@ghost ghost closed this as completed in e4235bb Jan 28, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant