Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Lazy-loading tree grid" test is invalid (and issue). #874

Closed
GordonSmith opened this issue Mar 23, 2014 · 5 comments
Closed

"Lazy-loading tree grid" test is invalid (and issue). #874

GordonSmith opened this issue Mar 23, 2014 · 5 comments

Comments

@GordonSmith
Copy link

  1. The code does not actually do a lazy load. To fix add "true" to the DeferredWrapper @ line 239:
testCountryStores= new Observable(new DeferredWrapper(testSyncCountryStore, true));
  1. Having made the change expand the bottom items:
    image
    Then click on "Show All", you then end up with:
    image
    Oddly to "fix" the view, you just need to move the "mouse over" the bottom few rows...
@kfranqueiro
Copy link
Member

Thanks for the report; we'll have to look into this. I have a feeling it's strongly related to the transitioning code in the tree module - it doesn't occur on older IE where CSS transitions aren't available, but it happens everywhere else I've tried.

@GordonSmith
Copy link
Author

Is there any way to "disable CSS transitions" as a workaround?

@dylans
Copy link
Member

dylans commented Apr 12, 2014

@GordonSmith a brute force method to test @kfranqueiro's comment would be to change https://github.com/SitePen/dgrid/blob/master/tree.js#L178 to hasTransitionend = false,

@ghost ghost closed this as completed in 94aac6d Jul 9, 2014
@kfranqueiro
Copy link
Member

@edhager investigated this and discovered there was some old code we could pull out to resolve this issue. Ed, @msssk, and myself all tested and couldn't find any adverse effects, so I've pushed the change.

I've also added an enableTransitions column definition property which can be set to false to more easily disable transitions in the event they cause more problems and need to be disabled for the time being. This will also be present at instance level in dgrid 0.4 via enableTreeTransitions.

@matsamuel
Copy link

It is documented that this issue has been fixed in dgrid 3.16 however we are using 3.16 and still seeing the same issue. As a temporary measure we are setting "enableTransitions" to "false" for the moment (as that alleviates the problem). Is it possible that this issue was re-introduced some how before 3.16 went out? It's also possible that I'm just seeing a different occurrence of the same problem. Either way can this issue please be re-opened?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants