Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Convert from dojo/compose to TS2.2 class mixins #108

Closed
maier49 opened this issue Feb 8, 2017 · 2 comments
Closed

Convert from dojo/compose to TS2.2 class mixins #108

maier49 opened this issue Feb 8, 2017 · 2 comments
Milestone

Comments

@maier49
Copy link
Contributor

maier49 commented Feb 8, 2017

Enhancement

TS2.2, currently a release candidate, adds support for class mixins. We should be able to leverage these native class mixins to replace dojo/compose.

This should be more familiar for consumers and provide a lower barrier of entry, and will enable stores to evolve with the latest/next enhancements in Typescript.

@maier49
Copy link
Contributor Author

maier49 commented Feb 9, 2017

This is partially blocked by microsoft/TypeScript#13979. We haven't found a way for a mixin to share a generic with a base class.

A potential workaround is to replace these uses of the mixin pattern with a compositional approach.

@dylans dylans modified the milestones: 2017.02, 2017.03 Mar 1, 2017
@maier49
Copy link
Contributor Author

maier49 commented Mar 9, 2017

In the end we could not work around the limitations caused by the above mentioned issue, and modifying TypeScript to support the desired pattern would be a very difficult and extensive change. As a result, the ObservableStore and QueryableStore are now separate base classes, rather than mixins.

@maier49 maier49 closed this as completed Mar 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants