Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Icons #1573

Open
matt-gadd opened this issue Nov 20, 2020 · 2 comments
Open

More Icons #1573

matt-gadd opened this issue Nov 20, 2020 · 2 comments
Labels
medium priority medium Medium size issue

Comments

@matt-gadd
Copy link
Contributor

Enhancement

The current icon set is very limited compared to say the material ui icon set.

@tomdye tomdye self-assigned this Mar 22, 2021
@tomdye tomdye added medium Medium size issue medium priority labels Mar 22, 2021
@tomdye
Copy link
Member

tomdye commented Mar 22, 2021

With regards to our icon set, I do not think we should continue with our own icon set, nor do I think we should try and theme across icon sets.
A better solution would be to support a subset of font-awesome / material icons etc without increasing our bundle size too much via <FontAwesome type='save'/> or similar.
This would remove the overhead of creating icons and maintaining a mapping between the icons of each design set across themes.

@tomdye tomdye removed their assignment Mar 26, 2021
@tomdye
Copy link
Member

tomdye commented Mar 26, 2021

Un-assigning myself from this as i concentrate on the grid work. I believe we should stick to simply extending the icon set we offer / use and support a single set. This could be done using SVG imports or by extending our icon selection in iconmoon. We need to assess the impact of either on our bundle size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority medium Medium size issue
Projects
None yet
Development

No branches or pull requests

2 participants