Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReducedFunctional should provide dual space derivatives #164

Open
jrmaddison opened this issue Aug 8, 2024 · 0 comments
Open

ReducedFunctional should provide dual space derivatives #164

jrmaddison opened this issue Aug 8, 2024 · 0 comments

Comments

@jrmaddison
Copy link
Contributor

Optimizers need access to dual space derivatives, and then the correct inner product should be used elsewhere, e.g. handing Riesz mapped derivatives to an optimizer doesn't work, #153. Currently ReducedFunctional.derivative and ReducedFunctional.hessian return Riesz mapped derivatives. This is worked around in #143 by discarding the return values and accessing adjoint variables directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant