Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show when we're unpacking an archive into the Git cache #2

Open
wants to merge 5 commits into
base: devenv-2.21
Choose a base branch
from
Open

Show when we're unpacking an archive into the Git cache #2

wants to merge 5 commits into from

Commits on Aug 8, 2024

  1. Show when we're unpacking an archive into the Git cache 

    This happens in parallel with the download (which starts later), so
you only see this message when the download has finished but the
import hasn't.
    @edolstra @shyim
    edolstra authored and shyim committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b24359b View commit details
    Browse the repository at this point in the history

  2. Warn if the download buffer is full

    @edolstra @shyim
    edolstra authored and shyim committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d93799a View commit details
    Browse the repository at this point in the history

  3. Add 'download-buffer-size' setting 

    We are piping curl downloads into `unpackTarfileToSink()`, but the
latter is typically slower than the former if you're on a fast
connection. So the download could appear unnecessarily slow. (There is
even a risk that if the Git import is *really* slow for whatever
reason, the TCP connection could time out.)

So let's make the download buffer bigger by default - 64 MiB is big
enough for the Nixpkgs tarball. Perhaps in the future, we could have
an unlimited buffer that spills data to disk beyond a certain
threshold, but that's probably overkill.
    @edolstra @shyim
    edolstra authored and shyim committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0d11f3d View commit details
    Browse the repository at this point in the history

  4. Log download durations

    @edolstra @shyim
    edolstra authored and shyim committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    23395a0 View commit details
    Browse the repository at this point in the history

  5. fix: conflict resolution

    @shyim
    shyim committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d2797e2 View commit details
    Browse the repository at this point in the history