Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add a key-binding to untile a window. #83

Open
qukhan opened this issue Jul 9, 2024 · 7 comments
Open

[Feature Request] Add a key-binding to untile a window. #83

qukhan opened this issue Jul 9, 2024 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed next release

Comments

@qukhan
Copy link

qukhan commented Jul 9, 2024

Describe the feature you'd like
We have key bindings to tile windows but we don't have one to do the reverse operation. It would be nice to avoid having to reach out to get the mouse just to untile a window.

@domferr
Copy link
Owner

domferr commented Jul 9, 2024

Hey @qukhan thank you for sharing this idea! I think it makes sense, which default keybinding you think would be a good one?

@domferr domferr added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 9, 2024
@qukhan
Copy link
Author

qukhan commented Jul 9, 2024

I'm not sure. I don't know if it's intended but my current setup has Meta + maximize the window when it can't go up anymore. So I'd say having Meta + untile the window when it can't go down anymore would feel the most intuitive.

@thyttan
Copy link

thyttan commented Jul 10, 2024

I vote against tying it to super+down. I'd prefer a separate keybinding.

But also, I think there's already a solution to this without tweaking Tiling shell.

There's a keyboard shortcut in the GNOME settings called 'Toggle fullscreen mode' that's disabled by default. You could set that to e.g. meta+ctrl+up to toggle between full screen and floating position.

(also, super+down will already today restore a maximized window to floating if that's the state it was in immediately prior to being maximized - I believe)

There's also a 'Toggle maximization State' one.

https://help.gnome.org/users/gnome-help/stable/keyboard-shortcuts-set.html.en (under the section 'Windows')

Edit: I realize now that my response is maybe not a direct response to the feature request.

@domferr
Copy link
Owner

domferr commented Jul 11, 2024

Yeah @thyttan, SUPER + is already used for so many things. @qukhan idea may work, however if you press SUPER + , and the window cannot be tiled on its monitor and you have a monitor below, Tiling Shell will move the window to the other monitor

I'm curious about the needs of this feature: if one wants to untile with keyboard because he/she doesn't want to use the mouse to do it, then after the window is untiled I believe that person would use the mouse to move the window... 😄

I believe that defining the ideal use case and reasons behind this feature would automatically tell us the right keybindings 😉

@qukhan
Copy link
Author

qukhan commented Jul 11, 2024

If the debate is about what key to set by default, I don't have a preference.

I generally don't work in maximized windows (for plenty of possible reasons: the app layout isn't convenient for large screens, I want to see some other app interface in the background, I want the app to be in a specific part of the screen, I tiled the window by mistake, etc). When I need to put two windows side by side, I tile them, do what I have to do, then close the one that isn't used anymore and un-tile the first one so that it moves back to its original position.

if you press SUPER + , and the window cannot be tiled on its monitor and you have a monitor below, Tiling Shell will move the window to the other monitor

Didn't this already work with the default Gnome shortcut Super + Shift + ? I've been using that and it works well. The behaviour you described however doesn't seem to work (I'm guessing it will in the next version).

@distefam
Copy link

distefam commented Aug 5, 2024

I would suggest Super + f, which is frequently used by tiling window managers and has the mnemonic to "float" a window (i.e., not tile it). Another option would be Super + t for "tile". "Float" seems to indicate that the default behavior is to tile, while "Tile" would be more useful if the default behavior is to "float" a window.

@domferr
Copy link
Owner

domferr commented Aug 8, 2024

Hey guys, here we go! This is going to be released with the next update of Tiling Shell. If you want to try it in advance and give some feedback, I leave here the files. Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed next release
Projects
None yet
Development

No branches or pull requests

4 participants