fix(globMatch): support implicit globs

.changeset/neat-carpets-roll.md

@@ -0,0 +1,5 @@
+---
+'tsconfck': patch
+---
+
+fix(glob-matching): add implicit **/\* to path patterns that do not have an extension or wildcard in their last segment, eg `src` becomes `src/**/\*` for matching.

packages/tsconfck/src/util.js

@@ -199,13 +199,35 @@ export function isGlobMatch(filename, dir, patterns, allowJs) {
 		// filename must end with part of pattern that comes after last wildcard
 		let lastWildcardIndex = pattern.length;
 		let hasWildcard = false;
+		let hasExtension = false;
+		let hasSlash = false;
+		let lastSlashIndex = -1;
 		for (let i = pattern.length - 1; i > -1; i--) {
-			if (pattern[i] === '*' || pattern[i] === '?') {
-				lastWildcardIndex = i;
-				hasWildcard = true;
+			const c = pattern[i];
+			if (!hasWildcard) {
+				if (c === '*' || c === '?') {
+					lastWildcardIndex = i;
+					hasWildcard = true;
+				}
+			}
+			if (!hasSlash) {
+				if (c === '.') {
+					hasExtension = true;
+				} else if (c === '/') {
+					lastSlashIndex = i;
+					hasSlash = true;
+				}
+			}
+			if (hasWildcard && hasSlash) {
 				break;
 			}
 		}
+		if (!hasExtension && (!hasWildcard || lastWildcardIndex < lastSlashIndex)) {
+			// add implicit glob
+			pattern += `${pattern.endsWith('/') ? '' : '/'}${GLOB_ALL_PATTERN}`;
+			lastWildcardIndex = pattern.length - 1;
+			hasWildcard = true;
+		}
 
 		// if pattern does not end with wildcard, filename must end with pattern after last wildcard
 		if (
@@ -243,11 +265,18 @@ export function isGlobMatch(filename, dir, patterns, allowJs) {
 			return false;
 		}
 
-		// if no wildcard in pattern, filename must be equal to resolved pattern
 		if (!hasWildcard) {
+			//  no wildcard in pattern, filename must be equal to resolved pattern
 			return filename === resolvedPattern;
+		} else if (
+			firstWildcardIndex + GLOB_ALL_PATTERN.length ===
+				resolvedPattern.length - (pattern.length - 1 - lastWildcardIndex) &&
+			resolvedPattern.slice(firstWildcardIndex, firstWildcardIndex + GLOB_ALL_PATTERN.length) ===
+				GLOB_ALL_PATTERN
+		) {
+			// singular glob-all pattern and we already validated prefix and suffix matches
+			return true;
 		}
-
 		// complex pattern, use regex to check it
 		if (PATTERN_REGEX_CACHE.has(resolvedPattern)) {
 			return PATTERN_REGEX_CACHE.get(resolvedPattern).test(filename);

packages/tsconfck/tests/fixtures/parse/solution/referenced-with-implicit-globs/src/foo.ts

@@ -0,0 +1,3 @@
+export function foo() {
+	return 'foo';
+}

packages/tsconfck/tests/fixtures/parse/solution/referenced-with-implicit-globs/tests/foo.test.ts

@@ -0,0 +1,9 @@
+import { foo } from '../src/foo';
+import * as assert from 'assert';
+
+function test() {
+	const actual = foo();
+	const expected = 'foo';
+	assert.strictEqual(actual, expected);
+}
+test();

packages/tsconfck/tests/fixtures/parse/solution/referenced-with-implicit-globs/tsconfig.json

@@ -0,0 +1,7 @@
+{
+  "files": [],
+  "references": [
+    {"path": "./tsconfig.src.json"},
+    {"path": "./tsconfig.test.json"}
+  ]
+}

packages/tsconfck/tests/fixtures/parse/solution/referenced-with-implicit-globs/tsconfig.src.json

@@ -0,0 +1,7 @@
+{
+  "include": ["src"],
+  "compilerOptions": {
+    "composite": true,
+    "strict": true
+  }
+}

packages/tsconfck/tests/fixtures/parse/solution/referenced-with-implicit-globs/tsconfig.test.json

@@ -0,0 +1,7 @@
+{
+  "include": ["tests"],
+  "compilerOptions": {
+    "composite": true,
+    "strict": false
+  }
+}

packages/tsconfck/tests/snapshots/parse/solution/referenced-with-implicit-globs/src/foo.ts.tsconfig.parse-native.ignore-files.json

@@ -0,0 +1,12 @@
+{
+	"files": [],
+	"references": [
+		{
+			"path": "./tsconfig.src.json"
+		},
+		{
+			"path": "./tsconfig.test.json"
+		}
+	],
+	"include": []
+}

packages/tsconfck/tests/snapshots/parse/solution/referenced-with-implicit-globs/src/foo.ts.tsconfig.parse-native.json

@@ -0,0 +1,9 @@
+{
+	"include": [
+		"src"
+	],
+	"compilerOptions": {
+		"composite": true,
+		"strict": true
+	}
+}

packages/tsconfck/tests/snapshots/parse/solution/referenced-with-implicit-globs/src/foo.ts.tsconfig.parse.json

@@ -0,0 +1,9 @@
+{
+	"include": [
+		"src"
+	],
+	"compilerOptions": {
+		"composite": true,
+		"strict": true
+	}
+}

packages/tsconfck/tests/snapshots/parse/solution/referenced-with-implicit-globs/tests/foo.test.ts.tsconfig.parse-native.ignore-files.json

@@ -0,0 +1,12 @@
+{
+	"files": [],
+	"references": [
+		{
+			"path": "./tsconfig.src.json"
+		},
+		{
+			"path": "./tsconfig.test.json"
+		}
+	],
+	"include": []
+}

packages/tsconfck/tests/snapshots/parse/solution/referenced-with-implicit-globs/tests/foo.test.ts.tsconfig.parse-native.json

@@ -0,0 +1,9 @@
+{
+	"include": [
+		"tests"
+	],
+	"compilerOptions": {
+		"composite": true,
+		"strict": false
+	}
+}

packages/tsconfck/tests/snapshots/parse/solution/referenced-with-implicit-globs/tests/foo.test.ts.tsconfig.parse.json

@@ -0,0 +1,9 @@
+{
+	"include": [
+		"tests"
+	],
+	"compilerOptions": {
+		"composite": true,
+		"strict": false
+	}
+}

packages/tsconfck/tests/snapshots/parse/solution/referenced-with-implicit-globs/tsconfig.json.parse-native.json

@@ -0,0 +1,11 @@
+{
+	"files": [],
+	"references": [
+		{
+			"path": "./tsconfig.src.json"
+		},
+		{
+			"path": "./tsconfig.test.json"
+		}
+	]
+}

packages/tsconfck/tests/snapshots/parse/solution/referenced-with-implicit-globs/tsconfig.json.parse.json

@@ -0,0 +1,11 @@
+{
+	"files": [],
+	"references": [
+		{
+			"path": "./tsconfig.src.json"
+		},
+		{
+			"path": "./tsconfig.test.json"
+		}
+	]
+}

packages/tsconfck/tests/snapshots/parse/solution/referenced-with-implicit-globs/tsconfig.src.json.tsconfig.parse.json

@@ -0,0 +1,9 @@
+{
+	"include": [
+		"src"
+	],
+	"compilerOptions": {
+		"composite": true,
+		"strict": true
+	}
+}

packages/tsconfck/tests/snapshots/parse/solution/referenced-with-implicit-globs/tsconfig.test.json.tsconfig.parse.json

@@ -0,0 +1,9 @@
+{
+	"include": [
+		"tests"
+	],
+	"compilerOptions": {
+		"composite": true,
+		"strict": false
+	}
+}