fix: display the invalid semver range as part of the error

dominykas · Mar 14, 2019 · 04c92ba · 04c92ba
1 parent f1e93b5
commit 04c92ba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -135,8 +135,7 @@ exports.run = async (options) => {
     packagesWithScripts
         .forEach((entry) => {
 
-            const path = entry.path;
-            const childPkg = entry.childPkg;
+            const { path, childPkg } = entry;
             const name = entry.childPkg.name;
 
             if (allowScripts[name] === undefined) {
@@ -155,7 +154,7 @@ exports.run = async (options) => {
             }
 
             if (!Semver.validRange(allowScripts[name])) {
-                errors.push(`${name} (invalid semver range)`);
+                errors.push(`${name} (invalid semver range: ${allowScripts[name]})`);
                 return;
             }
 

diff --git a/test/index.js b/test/index.js
@@ -190,7 +190,7 @@ describe('allow-scripts', () => {
                 'without-scripts'
             ]);
 
-            await expect(Allow.run({})).to.reject('Mis-configured allowedScripts: @example/with-install-script (invalid semver range)');
+            await expect(Allow.run({})).to.reject('Mis-configured allowedScripts: @example/with-install-script (invalid semver range: not-a-semver-range)');
 
             expect(fixture.getActualResult()).to.equal('');
             expect(fixture.getLog()).to.equal('');