fix(nx-mesh): dont cache validate executor output (#116)

domjtalbot · Jan 9, 2023 · a76a8ad · a76a8ad
1 parent edcf6dd
commit a76a8ad
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 16 deletions.
diff --git a/.changeset/many-dragons-reflect.md b/.changeset/many-dragons-reflect.md
@@ -0,0 +1,5 @@
+---
+'nx-mesh': patch
+---
+
+Don't cache validate executor
diff --git a/libs/example/sdk/graphql/star-wars-api/project.json b/libs/example/sdk/graphql/star-wars-api/project.json
@@ -43,6 +43,12 @@
         "dev": true,
         "dir": "libs/example/sdk/graphql/star-wars-api"
       }
+    },
+    "validate": {
+      "executor": "nx-mesh:validate",
+      "options": {
+        "dir": "libs/example/sdk/graphql/star-wars-api"
+      }
     }
   },
   "tags": ["type:example", "type:sdk"]

diff --git a/libs/nx-mesh/executors.json b/libs/nx-mesh/executors.json
@@ -40,8 +40,7 @@
     "validate": {
       "implementation": "./src/executors/validate/validate.impl",
       "schema": "./src/executors/validate/schema.json",
-      "description": "Validates artifacts",
-      "hasher": "./src/executors/validate/hasher"
+      "description": "Validates artifacts"
     }
   }
 }
diff --git a/libs/nx-mesh/src/generators/base/lib/set-defaults.ts b/libs/nx-mesh/src/generators/base/lib/set-defaults.ts
@@ -14,19 +14,6 @@ export function setDefaults(host: Tree, options: NormalizedOptions) {
     workspace.defaultProject = options.projectName;
   }
 
-  if (workspace.tasksRunnerOptions?.['default']?.runner === '@nrwl/nx-cloud') {
-    const cacheableOperations =
-      (workspace.tasksRunnerOptions['default'].options
-        ?.cacheableOperations as string[]) ?? [];
-
-    if (!cacheableOperations.includes('validate')) {
-      workspace.tasksRunnerOptions['default'].options = {
-        ...workspace.tasksRunnerOptions['default'].options,
-        cacheableOperations: [...cacheableOperations, 'validate'],
-      };
-    }
-  }
-
   if (workspace.targetDefaults) {
     workspace.targetDefaults = {
       ...workspace.targetDefaults,

diff --git a/nx.json b/nx.json
@@ -8,7 +8,7 @@
     "default": {
       "runner": "@nrwl/nx-cloud",
       "options": {
-        "cacheableOperations": ["build", "lint", "test", "e2e", "validate"],
+        "cacheableOperations": ["build", "lint", "test", "e2e"],
         "accessToken": "NzExMGIxYWUtZjdkYy00MjRjLWI5NjItMjlkYmU0OWRjNWY2fHJlYWQ="
       }
     }