Allow the use of generic type with Interface #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created EventInterface with methods: DateTime getDate() String getTitle() Widget getIcon() Widget getDot() Overrided method in class Event, now implements EventInterface
replaced all class Event with T now we can use any class that implements the interface
Valitutto
changed the title
|
Resolve #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created an interface with the methods to get the default fields of the event class and implemented it.
I then changed each occurrence of Event class with T class that extends the interface.
This will allow us to make the plugin work with any custom class (as I already do in some of my projects).
Of course with the default Event class it will continue to work because it implements EventInterface.