Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headerTitleTouchable and onHeaderTitlePressed props added #44

Merged
merged 1 commit into from Dec 28, 2018
Merged

headerTitleTouchable and onHeaderTitlePressed props added #44

merged 1 commit into from Dec 28, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 27, 2018 •
edited by ghost
Loading

I added headerTitleTouchable and onHeaderTitlePressed props.
By default headerTitleTouchable is set to false, so headerTitle will not react on tap while you don't change it to true.
If headerTitleTouchable is provided, but there is no onHeaderTitlePressed prop then it works like now (calling native calendar view).
If headerTitleTouchable is true, and onHeaderTitlePressed provided (it should be void? function), then tap on headerTitle calls onHeaderTitlePressed function.

@hyochan hyochan added enhancement New feature or request feature labels Dec 27, 2018
hyochan
hyochan reviewed Dec 27, 2018
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Please review the comment.

lib/flutter_calendar_carousel.dart Show resolved Hide resolved
@hyochan hyochan self-assigned this Dec 27, 2018
@hyochan hyochan merged commit 7b74dad into hyochan:master Dec 28, 2018
hyochan added a commit that referenced this pull request Dec 28, 2018
@hyochan
Release 1.3.5.
eb6df62 
#44
@hyochan
Copy link
Owner

hyochan commented Dec 28, 2018

@vkondratiev94 I've just merged this and released to 1.3.5. Could you also update the readme for us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hyochan hyochan

Labels
enhancement New feature or request feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hyochan