Fix discounts issues #1038
Merged
Fix discounts issues #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The product price uses `[product.price stringValue]`. This change updates the discount price to follow the same pattern.
If discount.priceLocale is nil, NSNumberFormatter defaults to the system locale, which may be different to the App Store locale. This change defaults the NSNumberFormatter locale to the App Store locale (taken from the product) if the discount priceLocale is nil.
hyochan
approved these changes
Jul 4, 2020
hyochan
added
🛠 bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a couple of issues related to discounts (aka introductory and promotional offers):
The product price is a string, but the discount price is a number. Fixed by taking the
stringValueofdiscount.pricewhen adding to thediscountdictionary.If
discount.priceLocaleisnil,NSNumberFormatterdefaults to the system locale rather than the App Store locale. Fixed by defaulting toproduct.priceLocaleifdiscount.priceLocaleisnil. Ifproduct.priceLocaleis alsonil,NSNumberFormatterwill then default to the system locale.