Fix promise not resolving on IOS14 #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Work in IOS 14 but error in IOS 13, 12... |
|
Hey @Hobahung, just tested on IOS 12 and no issue. |
|
Dear @iaphub iap It works well when it's not case renew, or renew less than 2 action. This error occurs when I renew an Non-Renewing Subscription or Consumable item several times a day. However, only the error on IOS is less than 14. The RNIap.requestPurchase function still returns the result on IOS14, however it doesn't work on iOS 10 or 12. I am also investigating the cause of this problem. Issue when i click buy button in attached photo. Please see attached photo.
|
|
I upgraded to the latest version 4.6.3 and it still not work on requestPurchase vs getSubscriptions. IOS 14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @hyochan,
We fixed an issue causing the
requestSubscriptionorrequestPurchasepromise to not resolve on IOS 14 (Issue: #1058)The issue is due to how react-native-iap is handling the promises, currently a key is generated (using RCTKeyForInstance) which is the pointer of the product identifier.
The problem is the pointer of
transaction.payment.productIdentifieris actually different in theupdatedTransactionsmethod on IOS 14 causing the key to identify the promise to be different therefore the promise isn't found.The solution in the pull request is to use directly the product identifier instead of the pointer value.