fixes subscription upgrade/downgrade #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyochan
approved these changes
Jul 30, 2021
mars-lan
reviewed
Aug 4, 2021
| @@ -87,7 +87,6 @@ public void getPurchaseHistoryByType(final String type, final Promise promise) { | |||
| public void buyItemByType( | |||
| final String type, | |||
| final String sku, | |||
| final String oldSku, | |||
There was a problem hiding this comment.
Dropping this without updating the TypeScript call site (https://github.com/dooboolab/react-native-iap/blob/master/src/iap.ts#L320) leads to an immediate crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
androidOldSku is no longer required for subscription changes. The parameter was being mixed up with the purchase token. I attempted to deprecate it but since it was a required field before. Many clients would have to set it to null. The cleanest way to deal with it is to mark it as a breaking change and move on