[Android] Fixed promise never returned from requestSubscription() #806
Conversation
| @@ -522,8 +522,8 @@ public void onPurchasesUpdated(BillingResult billingResult, @Nullable List<Purch | |||
| item.putBoolean("isAcknowledgedAndroid", purchase.isAcknowledged()); | |||
| item.putInt("purchaseStateAndroid", purchase.getPurchaseState()); | |||
|
|
|||
| promiseItem = item.copy(); | |||
There was a problem hiding this comment.
the copy method is only added in RN 0..61. Should probably bump up the major version and update doc to reflect that.
There was a problem hiding this comment.
@mars-lan Hey! Thank you for the detail. Um... I should have to think about it since I feel kind of reluctant to separate the major version. @rewieer How do you think?
There was a problem hiding this comment.
The copy method basically calls merge, so we can create a public WriteableMap copy(WritableMap original) inside DoobooUtils.java.
There was a problem hiding this comment.
@rewieer Sounds great! Would you like to give a PR for your idea?
There was a problem hiding this comment.
@hyochan sorry for the long delay, I was about to do it but it seems someone did it before me
Calling
requestSubscription()on Android result in the purchase being made but the promise is never called. This is due to an exception being thrown when trying to resolve the promise, specificallymethod threw 'com.facebook.react.bridge.objectalreadyconsumedexception' exceptionbecause the WriteableMap is already consumed whensendEventis called.By making a copy before calling it, we get a fresh WriteableMap that we can send to our promise without error.