Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fixed promise acceptation/rejection not propagated to JS #809

Merged
merged 1 commit into from
Oct 25, 2019
Merged

[iOS] Fixed promise acceptation/rejection not propagated to JS #809

merged 1 commit into from
Oct 25, 2019

Conversation

ancyrweb
Copy link

Hello again,
Just noticed that whenever the user cancel buying a product, or when the product is bought, nothing happens in JS because the resolve/reject methods aren't called properly.

This commit fixes it 😄

hyochan
hyochan approved these changes Oct 25, 2019
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising! Thank you.

@hyochan hyochan added the 🍗 enhancement New feature or request label Oct 25, 2019
@hyochan hyochan merged commit 7a303be into hyochan:master Oct 25, 2019
@hyochan hyochan mentioned this pull request Oct 25, 2019
Merged
hyochan added a commit that referenced this pull request Oct 25, 2019
@hyochan
Release/4.0.8 (#812)
24f67d4 
PR
- #806 
- #807 
- #809 

Resolve
- #811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
🍗 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ancyrweb @hyochan