Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some warnings and a bug #854

Merged
merged 2 commits into from
Nov 17, 2019
Merged

Fix some warnings and a bug #854

merged 2 commits into from
Nov 17, 2019

Conversation

mo22
Copy link
Contributor

@mo22 mo22 commented Nov 16, 2019

  • tsconfig.json should not be in the released module, this causes errors in some editors (atom-typescript)
  • fix Xcode warning (explicit self->hasListeners)
  • fix NSInteger vs. NSInteger* - the intended behaviour is probably quantity as NSInteger.

hyochan
hyochan approved these changes Nov 17, 2019
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the enhancement and fixes! Approved!

@hyochan hyochan added 🛠 bugfix All kinds of bug fixes 🍗 enhancement New feature or request labels Nov 17, 2019
@hyochan hyochan merged commit 08ed219 into hyochan:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
🛠 bugfix All kinds of bug fixes 🍗 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mo22 @hyochan