New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double precision issue and inconsistent return type on Android #885

Merged

hyochan merged 2 commits into hyochan:master from KKFARM-inc:master

Dec 27, 2019

Contributor

denkeni commented Dec 25, 2019

Fix double precision issue when doing calculations with large numbers. In our case, priceAmountMicros can be 3290000000, and priceAmountMicros / 1000000f will give incorrect value 3289.999755859375 (3290 is expected).
Fix inconsistent return type. On documentation and iOS implementation, all properties of Product are String types. Earlier implementation on Android gives Double type.

We also update documentation of price and localizedPrice to make it clearer.

denkeni added 2 commits

December 24, 2019 18:14


          Fix double precision issue and inconsistent return type on Android

0a275cb


          Improve document based on current implementations

1766e93

hyochan approved these changes

View reviewed changes

Owner

hyochan left a comment

Approve this Pull Request 🎉

hyochan added 🤖 android 🍗 enhancement labels

hyochan merged commit 34527fc into hyochan:master

voxspox mentioned this pull request

Types: normalize price type between iOS and Android #694

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 android 🍗 enhancement