Fixed DAPInstall.nvim auto install

[connorgmeehan]

The automatic installer had the same problem as #87 & #149.

Also it seems like the ColourScheme event wasn't triggering nvim-dap so I've removed lazy loading from it. Let me know if there's another autocommand that would be more suitable.

Additionally the api to install DAPs has changed so I've fixed that.

[connorgmeehan]

Continuing off the comment you left in #153, maintaining a lookup table matching each lang to a DAP wouldn't be too hard. Happy to add that.

[connorgmeehan]

I spent ages refactoring this to give more meaningful error messages:
Does not have a DAP client... when there are zero DAP clients and X DAP client for Y language does not exist for when there are multiple DAP clients and one of them fails (important for javascript/typescript which should install both jsnode and chrome) but I'm not really getting anywhere now :(.

The current implementation works and will automatically install DAP clients, and avoid duplicates. Let me know if you're happy with it.

---

Side note, do you have any recommendations of how to speed up the development cycle when working in a lua config? What I've been doing is having one nvim window that I use for testing my changes and I need to :qa!, reopen nvim package.json run :PackerCompile to compile my changes then quit and reopen it again before I can test what I'm working on.

[NTBBloodbath]

Hi buddy, my internet connection is dead since 2 hours ago haha I'm unlucky ig :p

but I'm not really getting anywhere now

Take your time, there's no hurry imo and since my net is dead then maybe I'll merge this tomorrow or when my net revives haha :p

The current implementation works and will automatically install DAP clients, and avoid duplicates. Let me know if you're happy with it.

Yeah this is good enough, thanks per this awesome work!

Side note, do you have any recommendations of how to speed up the development cycle when working in a lua config? What I've been doing is having one nvim window that I use for testing my changes and I need to :qa!, reopen nvim package.json run :PackerCompile to compile my changes then quit and reopen it again before I can test what I'm working on.

Hmm don't know if this could work but Doom automatized almost all the plugins stuff, that means if you modify a plugin config Doom will automatically run :PackerCompile and hot reload the plugin configuration (this last feature only in develop branch atm). However if you're are just modifying Doom's codebase (not plugins configs) you could try the :doautocmd VimEnter command that simulates a new Neovim launch, it's a hack and should work for some cases but haven't tested it out tho.

[NTBBloodbath]

Hi buddy, is it ready to merge? I feel like it's done but I don't know if you want to add extra stuff haha

Regards

[connorgmeehan]

Yep, it's good. Ready to merge!

[bavalpey]

Question on this: it seems to automatically install dap clients, but will it configure them? I've used DInstall python, but then it states that python is not configured.

[NTBBloodbath]

Hi, yeah it should. DAPInstall.nvim handles (un)installation and configuration of DAP clients. You can take a look here