Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puzzled by native use cases #1221

Closed
montdidier opened this issue Mar 25, 2019 · 3 comments
Closed

Puzzled by native use cases #1221

montdidier opened this issue Mar 25, 2019 · 3 comments
Milestone

Comments

@montdidier
Copy link
Contributor

montdidier commented Mar 25, 2019

When attempting to use the authentication_code flow with a native iOS application there seems to be a use case mismatch with the way doorkeeper is designed.

As far as I can tell with doorkeeper one should

  • set the redirect_uri in the native app
  • setup doorkeeper to recognise this url (application redirect_url)
  • set the native_redirect_uri to match in the doorkeeper initialiser

In an iOS application it seems almost expected (there may be other use cases I am not aware of) that one would use a registered custom scheme.

However doorkeeper does not redirect upon successful authentication to the expected custom scheme URI but instead redirects to the hardcoded URI of the style:

https://server.domain.tld/oauth/authorize/native?code=[CODE]

Which then presents the CODE in a view. This behaviour seems similar as what one would expect using the urn:ietf:wg:oauth:2.0:oob URI as per Google's documentation. The OOB request_uri hint never became a standard but Google still uses it.

As far as I understand it this approach has been superseded by the approach(es) documented in rfc8252. Doorkeeper as it currently is, doesn't seem to support any of these.

Short story. I would expect doorkeeper to return a redirect to the native app's custom scheme.

e.g. appname://oauth/callback?code=[CODE] or similar.

@nbulaj
Copy link
Member

nbulaj commented May 21, 2019

Hi @montdidier . I think we can close this issue, right?

@montdidier
Copy link
Contributor Author

@nbulaj Yes, we should close it.

@montdidier
Copy link
Contributor Author

Addressed in referenced issues and PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants