Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Sequel ORM #647

Closed
xtagon opened this issue May 1, 2015 · 9 comments
Closed

Feature Request: Sequel ORM #647

xtagon opened this issue May 1, 2015 · 9 comments

Comments

@xtagon
Copy link

xtagon commented May 1, 2015

Hi,

It seems Doorkeeper does not have an adapter for Sequel yet, but I would very much like to use Doorkeeper in a Rails app that uses Sequel, in which ActiveRecord is unavailable. Sequel supports most of the same functionality that ActiveRecord does, so I'm sure this is possible, but I'm not sure where to begin.

Would anyone be interested in providing a Sequel ORM adapter for Doorkeeper, or at least help to hold my hand while I fumble through making the adapter myself?

I took a look at the files in lib/doorkeeper/orm/... but being unfamiliar with Doorkeeper's source, I'm not clear on how it all works and ties together. Any pointers? I would really appreciate it.

😄

@tute
Copy link
Contributor

tute commented May 1, 2015

I'm very much interested. There's a PR in #281.

And there's a https://github.com/doorkeeper-gem/doorkeeper-orms project too, which I'd love to finish up integrating with doorkeeper.

@xtagon in an ideal world ORMs would work as plugins from their own repository, but I would merge a PR that incorporates sequel support into doorkeeper, provided it's reasonably encapsulated and it doesn't add significant complexity to existing files in the project.

Thanks for your input!

@xtagon
Copy link
Author

xtagon commented May 1, 2015

@tute Ah, that one didn't come up in my issue search. Thank you! I'll take a look at what has been done and find ways to contribute to the effort.

@xtagon xtagon closed this as completed May 1, 2015
@tute
Copy link
Contributor

tute commented May 4, 2015

You might want to work on this after we make doorkeeper-gem/doorkeeper-mongodb#2 work. ❤️

@xtagon
Copy link
Author

xtagon commented May 4, 2015

That sounds like a good idea. Subscribed.

@tute
Copy link
Contributor

tute commented May 12, 2015

PR merged! https://github.com/doorkeeper-gem/doorkeeper-mongodb is good basis for the next ORM extension to doorkeeper. 👍

@xtagon
Copy link
Author

xtagon commented May 12, 2015

Congrats, that's awesome. I'll play around with it when I get a chance.

@xtagon
Copy link
Author

xtagon commented May 12, 2015

Didn't do anything interesting to it yet but you can keep a watch here: https://github.com/xtagon/doorkeeper-sequel

@nbulaj
Copy link
Member

nbulaj commented Jul 5, 2016

Take a look at my doorkeeper-sequel extension. It is 100% compatible with Doorkeeper 4.0.0 and you can use it (gem uses all the specs that written for the original Doorkeeper gem).

@tute you can add this to the Readme if you wish to let people know about the Doorkeeper Sequel ORM.

@tute
Copy link
Contributor

tute commented Jul 5, 2016

Absolutely! Thanks for your work, @nbulaj. Please send a PR adding the link, and I will merge it in. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants