Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add proper testing for distributed dataflows #475

Open
phil-opp opened this issue Apr 18, 2024 · 2 comments
Open

CI: Add proper testing for distributed dataflows #475

phil-opp opened this issue Apr 18, 2024 · 2 comments
Labels

Comments

@phil-opp
Copy link
Collaborator

Our current CI test runs the coordinator and two daemons on the same machine. To ensure that dora is able to communicate across machines, we would need to use three different machines with different IPs. I'm not sure if something like this is possible on GitHub actions, so this issue is mostly a reminder to look into this further.

Notes:

@Michael-J-Ward
Copy link
Contributor

As far as I can tell, the examples runners in CI serve as dora's integration tests. Run Completes = Green, but nothing verifies the output of the run - is that correct?

Are any of them deterministic enough that we could throw a snapshot tests on the output / logs - or otherwise test "successful end state"?

@phil-opp
Copy link
Collaborator Author

Yes, we don't very the output, as it's not deterministic enough. We just check the exit code of the process, which should be != 0 when an error occurs. We also have some examples with assertions, for example for verifying that the ROS2 turtle is at a different position at the end of the test (to ensure that it moved).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants