From e091fade5c67a58e8b7f92a35df00a9f942f9975 Mon Sep 17 00:00:00 2001 From: Jozef Izso Date: Tue, 12 Dec 2023 15:11:55 +0100 Subject: [PATCH] Use NodeJS 18 LTS as default runtime --- .github/workflows/check-dist.yml | 6 +++--- .github/workflows/ci.yml | 4 +++- .nvmrc | 2 +- package-lock.json | 16 ++++++++++++---- package.json | 2 +- 5 files changed, 20 insertions(+), 10 deletions(-) diff --git a/.github/workflows/check-dist.yml b/.github/workflows/check-dist.yml index 22b61c21..5f4b9d2e 100644 --- a/.github/workflows/check-dist.yml +++ b/.github/workflows/check-dist.yml @@ -23,10 +23,10 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Set Node.js 16.x - uses: actions/setup-node@v3 + - name: Set Node.js + uses: actions/setup-node@v4 with: - node-version: 16.x + node-version-file: '.nvmrc' - name: Install dependencies run: npm ci diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 12b8778e..545b4e37 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,7 +14,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - run: node --version + - uses: actions/setup-node@v4 + with: + node-version-file: '.nvmrc' - run: npm ci - run: npm run build - run: npm run format-check diff --git a/.nvmrc b/.nvmrc index 79bdb1b9..eb800ed4 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v18.7.0 +v18.19.0 diff --git a/package-lock.json b/package-lock.json index af445a1a..fe951e8a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -25,7 +25,7 @@ "@types/adm-zip": "^0.5.0", "@types/github-slugger": "^1.3.0", "@types/jest": "^28.1.7", - "@types/node": "^18.7.7", + "@types/node": "^18.19.3", "@types/picomatch": "^2.2.1", "@types/xml2js": "^0.4.8", "@typescript-eslint/eslint-plugin": "^5.33.1", @@ -1792,9 +1792,12 @@ } }, "node_modules/@types/node": { - "version": "18.17.18", - "resolved": "https://registry.npmjs.org/@types/node/-/node-18.17.18.tgz", - "integrity": "sha512-/4QOuy3ZpV7Ya1GTRz5CYSz3DgkKpyUptXuQ5PPce7uuyJAOR7r9FhkmxJfvcNUXyklbC63a+YvB3jxy7s9ngw==" + "version": "18.19.3", + "resolved": "https://registry.npmjs.org/@types/node/-/node-18.19.3.tgz", + "integrity": "sha512-k5fggr14DwAytoA/t8rPrIz++lXK7/DqckthCmoZOKNsEbJkId4Z//BqgApXBUGrGddrigYa1oqheo/7YmW4rg==", + "dependencies": { + "undici-types": "~5.26.4" + } }, "node_modules/@types/picomatch": { "version": "2.3.0", @@ -7464,6 +7467,11 @@ "url": "https://github.com/sponsors/ljharb" } }, + "node_modules/undici-types": { + "version": "5.26.5", + "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-5.26.5.tgz", + "integrity": "sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==" + }, "node_modules/universal-user-agent": { "version": "6.0.0", "resolved": "https://registry.npmjs.org/universal-user-agent/-/universal-user-agent-6.0.0.tgz", diff --git a/package.json b/package.json index b8dff4ef..80da1b5a 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,7 @@ "@types/adm-zip": "^0.5.0", "@types/github-slugger": "^1.3.0", "@types/jest": "^28.1.7", - "@types/node": "^18.7.7", + "@types/node": "^18.19.3", "@types/picomatch": "^2.2.1", "@types/xml2js": "^0.4.8", "@typescript-eslint/eslint-plugin": "^5.33.1",