-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'list-tests: failed' still reporting successful tests. #142
Comments
I am having the same problem. @dorny I would like to contribute a fix for this. Could you please provide some information on how to set up the project locally for development? Note: I have only very little experience with type-script. See test-reporter/src/report/get-report.ts Lines 230 to 240 in a585725
I suspect that a fix for this problem would be to add an additional if statement right after line 233. if (options.listTests === 'failed' && tc.result !== 'failed') {
continue;
} Any guidance on how to contribute would be appreciated. Thanks! |
This is now fixed at https://github.com/phoenix-actions/test-reporting |
@dharmendrasha can you please check fix in phoenix-actions and implement it here as well? 🙏 |
Sorry guys for being late let me check on it |
this is still borked - switching to phoenix-actions/test-reporting fork for now.. |
Hi everyone, I'm experiencing this issue as well (see here), is there anything I could do to get it to show only the failed tests? |
FYI this fix in the fork is here |
I'm trying to process a junit that exceeds the max report size, so I'm setting 'list-tests: failed' , but the test report is still showing all of the successful tests.
Resulting report:
![image](https://user-images.githubusercontent.com/83664244/136110639-bad7bb77-0204-4349-b12f-c4ab1a8bffb3.png)
The text was updated successfully, but these errors were encountered: