Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include IP address in the User Activity Log for Add, Modify, Delete user #30678

Closed
patrick-schweiger opened this issue Nov 15, 2024 · 3 comments · Fixed by #30850
Closed

Include IP address in the User Activity Log for Add, Modify, Delete user #30678

patrick-schweiger opened this issue Nov 15, 2024 · 3 comments · Fixed by #30850
Assignees
@gortiz-dotcms
Labels
Next Release OKR : Customer Support Owned by Scott QA : Passed Internal Team : Bug Fixers Type : New Functionality

Comments

@patrick-schweiger
Copy link

Parent Issue

No response

User Story

dotCMS logs do not currently include the user IP address in the User Activity logs for Adding a User, Modifying, and Deleting a User. DB is requesting that the IP address information be added to these logs as this is a requirement from their internal access control team.

Acceptance Criteria

The user IP address should be present in the user activity logs for Add, Modify, and Delete user.

Proposed Objective

Security & Privacy

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.airfocus.com/DF-49
https://helpdesk.dotcms.com/a/tickets/28384

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@erickgonzalez erickgonzalez moved this from New to Current Sprint Backlog in dotCMS - Product Planning Nov 18, 2024
@gortiz-dotcms gortiz-dotcms moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Dec 3, 2024
@gortiz-dotcms gortiz-dotcms self-assigned this Dec 3, 2024
gortiz-dotcms added a commit that referenced this issue Dec 4, 2024
@gortiz-dotcms
chore: added ip data in the user activity logs (#30678)
a3d75fb
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

PRs:

gortiz-dotcms added a commit that referenced this issue Dec 4, 2024
@gortiz-dotcms
chore: beautify string (#30678)
bd394e9
@gortiz-dotcms gortiz-dotcms moved this from In Progress to In Review in dotCMS - Product Planning Dec 4, 2024
@erickgonzalez
Copy link
Contributor

Let's add the IP also when starting to exec the action

@erickgonzalez erickgonzalez moved this from In Review to In Progress in dotCMS - Product Planning Dec 4, 2024
gortiz-dotcms added a commit that referenced this issue Dec 5, 2024
@gortiz-dotcms
chore: add missing ip address string (#30678)
e63b81f
@gortiz-dotcms gortiz-dotcms moved this from In Progress to In Review in dotCMS - Product Planning Dec 5, 2024
@github-actions github-actions bot mentioned this issue Dec 10, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Dec 11, 2024
@erickgonzalez
Copy link
Contributor

Working as it should.

Adding User:

[11/12/24 17:12:40:112 GMT]  INFO ajax.UserAjax: User Added : Date: 2024-12-11 17:12:39; IP: 201.203.117.121; User:dotcms.org.1
[11/12/24 17:12:40:112 GMT]  INFO util.AdminLogger: class com.dotmarketing.portlets.user.ajax.UserAjax : User Added : Date: 2024-12-11 17:12:39; IP: 201.203.117.121; User:dotcms.org.1

Update User:

[11/12/24 17:14:09:968 GMT]  INFO util.AdminLogger: class com.dotmarketing.portlets.user.ajax.UserAjax : User Updated : Date: 2024-12-11 17:14:09; IP: 201.203.117.121; User:dotcms.org.1
[11/12/24 17:14:19:334 GMT]  INFO util.SecurityLogger: class com.dotmarketing.business.RoleAPIImpl : Adding role:'Publisher / Legal' to user:user-296cec60-8961-4a7d-a505-a26fdeacad59 email:new@dotcms.com -- ip:201.203.117.121,user:Admin User [ID: dotcms.org.1][email:admin@dotcms.com]

Delete User:

[11/12/24 17:15:23:099 GMT]  INFO util.ActivityLogger: class com.dotmarketing.portlets.user.ajax.UserAjax: system : Deleting user , User IP: 201.203.117.121
[11/12/24 17:15:23:276 GMT]  INFO util.AdminLogger: class com.dotmarketing.portlets.user.ajax.UserAjax : User Deleted : Date: 2024-12-11 17:15:23; IP: 201.203.117.121; User:user-296cec60-8961-4a7d-a505-a26fdeacad59; Replaced entries with User:dotcms.org.2808

@erickgonzalez erickgonzalez moved this from Internal QA to Done in dotCMS - Product Planning Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gortiz-dotcms gortiz-dotcms

Labels
Next Release OKR : Customer Support Owned by Scott QA : Passed Internal Team : Bug Fixers Type : New Functionality
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 30678 Include IP Address in user activity logs dotCMS/core
3 participants
@erickgonzalez @gortiz-dotcms @patrick-schweiger