[experimental-graphql-modules] no config in generation for enums

[maapteh]

Im using the new experimental graphql-module creation. In the old schema creation we had this config:

        config:
            constEnums: true
            avoidOptionals: true
            namingConvention:
                enumValues: change-case#upperCase

Now the new graphql-modules option creates the complete schema but i cant set any config. So i lost all my enums basically (which follow TS spec, also saw it with DTS generator). I can create the other as well, but why having two schemas :)

example new situation:

/** Order your items */
export type BasketListOrdering = 
  /** By department, which is based on product taxonomy */
  | 'DEPARTMENT'
  /** By latest item added first */
  | 'INPUT';

example old situation:

/** Order your items */
export const enum BasketListOrdering {
    /** By department, which is based on product taxonomy */
    DEPARTMENT = 'DEPARTMENT',
    /** By latest item added first */
    INPUT = 'INPUT',
}

btw really cool to see the progress on the suite!

[dotansimha]

Hi!
Thank you for reporting it.
We do allow custom configurations, but not for enums customizations.

In this new preset, we generate main types file with everything in it, and then generate types file per graphql-module, with the contribution of it to the result schema.

Since TypeScript enums are nominal types, we can define the entire enum in the main file, and the pick specific values from it.
The only way to allow this kind of flow where main types files defined everything and each module types file takes what it needs is to use const string enums, instead of enum.

Do you think there is another way to solve that?

[maapteh]

No not really unfortunately. I hope to work on it next year since now i only have three working days left :)

[jjangga0214]

@dotansimha
@maapteh

The only way to allow this kind of flow where main types files defined everything and each module types file takes what it needs is to use const string enums, instead of enum.

Do you think there is another way to solve that?

I don't understand why.. just importing typescript enum from main file to module file, like what config: enumsAsTypes would do, isn't enough to solve that?

P.S.
Currently, config: enumsAsTypes does not work with graphql-modules preset, and I feel this is inconsistent in a natural user's viewpoint.

[jjangga0214]

Workaround for other folks until the issue is resolved.

You can generate typescript enum only with typescript (without graphql-modules).
Then, you can configure config: enumsValues (ref1, ref2) on graphql-modules generation.

overwrite: true
generates:
  ./src/generated/graphql/self-enum.ts:
    schema:
      - ./src/graphql/module/*/*.graphql:
          commentDescriptions: true
    plugins:
      - typescript
    config:
      typesPrefix: Gql
  ./src/graphql/module:
    schema:
      - ./src/graphql/module/*/*.graphql:
          commentDescriptions: true
    preset: graphql-modules
    presetConfig:
      baseTypesPath: ../../generated/graphql/self.ts # Where to create the complete schema types
      filename: generated.ts # Where to create each module types
    plugins:
      - typescript
      - typescript-resolvers
    config:
      typesPrefix: Gql
      # enumsAsTypes: false # This does not work with graphql-modules preset. 
      enumValues:
        foo: ./self-enum#GqlFoo
        bar: ./self-enum#GqlBar

And you can import enum types independently.

import { YourModule } from './generated'
import { GqlFooEnum, GqlBarEnum } from '../../../generated/garphql/self-enum'

// the enums are compatible with graphql-modules' generated enums.