Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module level let detupling #897

Closed
Jand42 opened this issue Feb 5, 2018 · 0 comments
Closed

Module level let detupling #897

Jand42 opened this issue Feb 5, 2018 · 0 comments

Comments

@Jand42
Copy link
Member

Jand42 commented Feb 5, 2018

    let a, b = 1, 2

in a module currently fails with Method name not found in JavaScript compilation: (patternInput@12-27 : unit -> (System.Int32 * System.Int32)).

This was a limitation in WebSharper 3 because of unsuitable behavior of F# compiler around module-level pattern lets with ReflectedDefinion (see #346), but should not be an issue with WebSharper 4 (using FCS).

The bug is caused by ignoring compiler generated methods of F# types. F# module, record and union properties, union case constructor methods and so on are treated specially, but patternInput here is also a module property is not exposed as a SourceMember definition by FCS.

@Jand42 Jand42 added the bug label Feb 5, 2018
@Jand42 Jand42 mentioned this issue Feb 5, 2018
@Jand42 Jand42 closed this as completed in 9680e95 Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant