Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0: gRPC: http.proto and annotations.proto are now included and auto referenced #29080

Closed
wadepickett opened this issue Apr 25, 2023 · 0 comments · Fixed by #29279
Closed

8.0: gRPC: http.proto and annotations.proto are now included and auto referenced #29080

wadepickett opened this issue Apr 25, 2023 · 0 comments · Fixed by #29279
Assignees
Labels
8.0 .NET 8 doc-out-of-date Doc is out of date with the current version gRPC Pri1 seQUESTered Identifies that an issue has been imported into Quest. Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

@wadepickett
Copy link
Contributor

wadepickett commented Apr 25, 2023

In just the 8.0 version of the document, update the Usage section so it no longer instructs to add http.proto and annotations.proto, Also in step one consider noting those packages are included with the NuGet package.

Do a sweep to look for any other topics where the same update is needed.

Copying http.proto and annotations.proto files into the app is no longer required. As of .NET 8 preview 1 those files are included in the NuGet package and automatically referenced.

See: [gRPC JSON transcoding no longer requires http.proto and annotations.proto(]https://devblogs.microsoft.com/dotnet/asp-net-core-updates-in-dotnet-8-preview-1/#grpc-json-transcoding-no-longer-requires-http-proto-and-annotations-proto
gRPC JSON transcoding no longer requires http.proto and annotations.proto)


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.


Associated WorkItem - 87021

@wadepickett wadepickett added Pri1 gRPC doc-out-of-date Doc is out of date with the current version 8.0 .NET 8 labels Apr 25, 2023
@wadepickett wadepickett self-assigned this Apr 25, 2023
@dotnet-bot dotnet-bot added ⌚ Not Triaged Source - Docs.ms Docs Customer feedback via GitHub Issue labels Apr 25, 2023
@wadepickett wadepickett added the reQUEST Triggers an issue to be imported into Quest label Apr 25, 2023
@github-actions github-actions bot added seQUESTered Identifies that an issue has been imported into Quest. and removed reQUEST Triggers an issue to be imported into Quest labels Apr 26, 2023
@wadepickett wadepickett moved this to 🏗 In progress in dotnet/AspNetCore.Docs May 2023 May 11, 2023
@wadepickett wadepickett moved this from 🏗 In progress to 👀 In review in dotnet/AspNetCore.Docs May 2023 May 22, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in dotnet/AspNetCore.Docs May 2023 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.0 .NET 8 doc-out-of-date Doc is out of date with the current version gRPC Pri1 seQUESTered Identifies that an issue has been imported into Quest. Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants