Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Razor directive ordering #31191

Closed
guardrex opened this issue Dec 4, 2023 · 0 comments · Fixed by #31192
Closed

Razor directive ordering #31191

guardrex opened this issue Dec 4, 2023 · 0 comments · Fixed by #31192
Assignees
@guardrex
Labels
Blazor doc-enhancement Pri1

Comments

@guardrex
Copy link
Collaborator

guardrex commented Dec 4, 2023 •
edited
Loading

Description

Without vertical spacing ...

  1. @page
  2. @rendermode
  3. @using directives (ordering: System, Microsoft, app)
  4. Others in alphabetical order

This ordering is approximately what the PU repo components do. They aren't completely consistent.

Most components already use this ordering, and this issue is to find and update any don't adopt the convention. I'd also like to call out the ordering in a bullet point in the Razor components section.

Page URL

https://learn.microsoft.com/en-us/aspnet/core/blazor/fundamentals/?view=aspnetcore-8.0

Content source URL

https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/fundamentals/index.md

Document ID

618e1209-44b8-c367-13e7-fbcfc26b07ea

Article author

@guardrex
@guardrex guardrex added Source - Docs.ms Docs Customer feedback via GitHub Issue ⌚ Not Triaged labels Dec 4, 2023
@github-project-automation github-project-automation bot moved this to Triage in Blazor.Docs Dec 4, 2023
@github-actions github-actions bot added the Blazor label Dec 4, 2023
@guardrex guardrex mentioned this issue Dec 4, 2023
Closed
@guardrex guardrex added Pri1 doc-enhancement and removed Source - Docs.ms Docs Customer feedback via GitHub Issue labels Dec 4, 2023
@guardrex guardrex moved this from Triage to In progress in Blazor.Docs Dec 4, 2023
@dotnet dotnet deleted a comment from github-actions bot Dec 4, 2023
@guardrex guardrex changed the title Confirm/update Razor directive ordering Razor directive ordering Dec 4, 2023
@guardrex guardrex mentioned this issue Dec 4, 2023
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in Blazor.Docs Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guardrex guardrex

Labels
Blazor doc-enhancement Pri1
Projects
Blazor.Docs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Razor directive ordering dotnet/AspNetCore.Docs
2 participants
@guardrex @dotnet-bot