Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Razor component Identity UI for BWAs #31271

Closed
kevon-vems opened this issue Dec 19, 2023 · 7 comments · Fixed by #31378
Closed

Cover Razor component Identity UI for BWAs #31271

kevon-vems opened this issue Dec 19, 2023 · 7 comments · Fixed by #31378
Assignees
Labels
8.0 .NET 8 Blazor doc-idea Pri1 Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

@kevon-vems
Copy link

kevon-vems commented Dec 19, 2023

[EDIT by guardrex to update the assignment and metadata]

Description

Current documentation still refers to cshtml documents, but the new templates are all using razor files.

Alternately, if this article is not for Blazor, then the template which has the links to the KB articles needs to be updated to point at the correct one.

Page URL

NEW DOC

Content source URL

NONE

Document ID

N/A

Article author

@guardrex

@dotnet-bot dotnet-bot added ⌚ Not Triaged aspnet-core/prod Source - Docs.ms Docs Customer feedback via GitHub Issue labels Dec 19, 2023
@guardrex
Copy link
Collaborator

cc: @JeremyLikness @halter73 ... Is there a plan to address this for Blazor Web Apps? We can place coverage in the Blazor Security node if not (and I'll update the metadata here if that's the case). If we do that, then the KB link that @kevon-vems is referring to can receive an updated link.

@kevon-vems ... Can you be more specific on "the template which has the links to the KB articles"? Do you mean the Blazor Web App template?

I see one thing that requires a quick update. The scaffolding guidance still claims that there aren't Razor components for Identity UI. I'll take care of that update now.

@kevon-vems
Copy link
Author

@JeremyLikness Yes, the blazor web app template has links to what appears to be the MVC related KB.

I'm working on creating a project with Identity and there are several links in the Blazor Web App template that seem not to be quite right

@guardrex
Copy link
Collaborator

I'm not surprised. We haven't reached it yet. I've been putting out 🔥 ever since release, and this is another one that we'll need to address ASAP 🚓🚒🚑. It won't be until after the 🎆 holidays tho. Everyone has just about bugged out until '24, and I'll be doing the same shortly.

@Rick-Anderson ... I'll take this one, and I suspect that we'll ...

  • Create new coverage in the Blazor Security and Identity node.
  • Have the template links updated to point to the new coverage.

@guardrex guardrex self-assigned this Dec 19, 2023
@github-project-automation github-project-automation bot moved this to Triage in Blazor.Docs Dec 19, 2023
@guardrex guardrex moved this from Triage to 8.0 in Blazor.Docs Dec 19, 2023
@guardrex guardrex changed the title Needs to be updated for the new .Net 8 templates Cover Razor component Identity UI for BWAs Dec 19, 2023
@dotnet dotnet deleted a comment from github-actions bot Dec 19, 2023
@guardrex
Copy link
Collaborator

guardrex commented Jan 2, 2024

UPDATE (1/2): I'm back from vacation, and I'll get to this as soon as I can. 🏃🏃🏃🏃

@kevon-vems
Copy link
Author

Awesome!! Hope you had a great holiday!

I was wondering if you could point me at the code for the templates. I was considering altering them and creating a PR for a different issue I have.

@guardrex
Copy link
Collaborator

guardrex commented Jan 2, 2024

If you mean the framework's project templates, they're here ...

https://github.com/dotnet/aspnetcore/tree/main/src/ProjectTemplates/Web.ProjectTemplates

The project files are in that folder, and the content folder has the actual template folders/files.

@guardrex
Copy link
Collaborator

guardrex commented Jan 8, 2024

I've looked things over, and I think we'll update ...

https://learn.microsoft.com/en-us/aspnet/core/blazor/security/server/?view=aspnetcore-8.0&tabs=visual-studio#blazor-identity-ui-individual-accounts

... with a cross-link to the components in the framework repo, specifically the Account folder, which is above the components in the Pages and Shared folders ...

https://github.com/dotnet/aspnetcore/tree/main/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account

Devs will be able to quickly reach the code to see what these Identity components look like without having to actually scaffold them into an app for inspection.

The naming makes the purpose of each component self-exclamatory. Implementations are subject to churn in the immediate future, so detailed explanations probably aren't wise at this point.

@kevon-vems, you didn't say exactly what URL those links are or where they are in the project template. I didn't see them in a casual inspection. If you know the exact link(s), could you state that here? I can then search their repo for them, identify the ones that are in the BWA template, and ask them update them.

@guardrex guardrex moved this from 8.0 to In progress in Blazor.Docs Jan 8, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Blazor.Docs Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.0 .NET 8 Blazor doc-idea Pri1 Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants