fix: Modify logging behavior when explicitly adding NullLogger with custom config #2594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix problem no console log is outputted when following conditions met.
NullLogger
explicitlyGlobal Config
(passing config asBenchmarkSwitcher::Run
parameters)..Currently BenchmarkDotNet use
ConsoleLogger
to print errors and list of benchmarks if logger is not enabled.But when explicitly set
NullLogger
it's not works and no console logs are outputted.Background
I'm trying to write custom progress logger that resolve #190 issue.
And it'll be implemented by using custom
EventProcessor
that is added from v0.13.9.So It need to suppress default
ConsoleLogger
by addingNullLogger
.Because when no logger specified following error is recorded.
It works almost as intended.
But when passing custom config to
BenchmarkSwitcher::Run
argument. console log is not outputted.