Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest 18.1.0 release breaks type remapping for args with spaces in them #554

Open
kkukshtel opened this issue May 24, 2024 · 2 comments
Open

Comments

@kkukshtel
Copy link
Contributor

As the title says:

Having this line in the rsp:

--remap
__arglist=@params string[] args

Used to work in previous versions by now throws:

Error: Invalid key/value pair argument: string[]. Expected 'name=value'
Error: Invalid key/value pair argument: args. Expected 'name=value'

I was trying to track down the issue and it seems like it's something to do with how the arguments are directly parsed, not the actual logic for extracting them in ParseKeyValuePairs. It seems like maybe context.ParseResult.GetValueForOption maybe splits on spaces so it's resolving multiple arguments instead of a single one?

@tannergooding
Copy link
Member

What was the previous version you were on?

There was likely some break or change in System.CommandLine that was missed and we'll need to add a workaround.

@kkukshtel
Copy link
Contributor Author

kkukshtel commented May 24, 2024

I was on 17.0.4. And yeah I agree - I think it has to do with option parsing in System.CommandLine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants