From b7c4007d0deb2c2ffa8281f7f731a59f42a5fce1 Mon Sep 17 00:00:00 2001
From: David Engel <v-davidengel@microsoft.com>
Date: Fri, 24 May 2024 10:21:39 -0700
Subject: [PATCH] Enhancement | Add trace logs for packet size (#2522)

---
 .../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs          | 3 +++
 .../netfx/src/Microsoft/Data/SqlClient/TdsParser.cs            | 3 +++
 .../src/Microsoft/Data/SqlClient/TdsParserStateObject.cs       | 3 +++
 3 files changed, 9 insertions(+)

diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
index abb16eaebe..8a5ed05abe 100644
--- a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
+++ b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
@@ -2740,6 +2740,9 @@ private bool TryProcessEnvChange(int tokenLength, TdsParserStateObject stateObj,
                         // to MARS initialization!
                         int packetSize = int.Parse(env._newValue, NumberStyles.Integer, CultureInfo.InvariantCulture);
 
+                        SqlClientEventSource.Log.TryTraceEvent("{0}.{1} | Info | Server sent env packet size change of {2}, ClientConnectionID {3}",
+                            nameof(TdsParser), nameof(TryProcessEnvChange), packetSize, _connHandler._clientConnectionId);
+
                         if (_physicalStateObj.SetPacketSize(packetSize))
                         {
                             // If packet size changed, we need to release our SNIPackets since
diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
index 7c8fc724c6..afa5220563 100644
--- a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
+++ b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
@@ -3182,6 +3182,9 @@ private bool TryProcessEnvChange(int tokenLength, TdsParserStateObject stateObj,
                         // to MARS initialization!
                         int packetSize = int.Parse(env._newValue, NumberStyles.Integer, CultureInfo.InvariantCulture);
 
+                        SqlClientEventSource.Log.TryTraceEvent("{0}.{1} | Info | Server sent env packet size change of {2}, ClientConnectionID {3}",
+                            nameof(TdsParser), nameof(TryProcessEnvChange), packetSize, _connHandler._clientConnectionId);
+
                         if (_physicalStateObj.SetPacketSize(packetSize))
                         {
                             // If packet size changed, we need to release our SNIPackets since
diff --git a/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs b/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
index 4aadbee4bd..4347d0f2e0 100644
--- a/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
+++ b/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
@@ -1097,6 +1097,9 @@ internal bool SetPacketSize(int size)
                           (_outBytesUsed == _outputHeaderLen && _outputPacketNumber == 1),
                           "SetPacketSize called with data in the buffer!");
 
+            SqlClientEventSource.Log.TryTraceEvent("{0}.{1} | Info | State Object Id {2}, Setting packet size to {3}",
+                nameof(TdsParserStateObject), nameof(SetPacketSize), _objectID, size);
+
             if (_inBuff == null || _inBuff.Length != size)
             { // We only check _inBuff, since two buffers should be consistent.
                 // Allocate or re-allocate _inBuff.