Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement async transaction commit/rollback methods #113

Open
roji opened this issue May 22, 2019 · 4 comments
Open

Implement async transaction commit/rollback methods #113

roji opened this issue May 22, 2019 · 4 comments
Labels
💡 Enhancement New feature request
Milestone

Comments

@roji
Copy link
Member

roji commented May 22, 2019

.NET Core 3.0 will fill in some missing async APIs (e.g. transaction management), these should be implemented in SqlClient at some point.

https://github.com/dotnet/corefx/issues/35012

@roji
Copy link
Member Author

roji commented May 23, 2019

(note: these should hopefully also make it into .NET Standard 2.1)

@Wraith2
Copy link
Contributor

Wraith2 commented May 24, 2019

Is there written guidance anywhere on the suggested patterns of do and don't for implementing IAsyncDisposable?

@roji
Copy link
Member Author

roji commented May 24, 2019

I'm not sure there's an "official" guide or anything, but the basic idea is to bring the instance to the same state it would have had if Dispose() was called, except that all I/O and other blocking calls need to be done asynchronously. The rest is going to depend on your specific implementation (e.g. whether any code can be shared between Dispose() and DisposeAsync()).

@cheenamalhotra cheenamalhotra added this to the Future milestone Jul 2, 2019
@roji roji changed the title Implement new async methods coming in .NET Core 3.0 Implement new async methods in .NET Standard 2.1 Oct 26, 2019
@roji
Copy link
Member Author

roji commented Jul 29, 2020

Note this user complaint about the lack of async transaction APIs: dotnet/efcore#21818. Not sure how complex this is to implement, but I'm hoping it can be done at some point to unblock perf issues such as this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Enhancement New feature request
Projects
None yet
Development

No branches or pull requests

3 participants