Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure.Identity to 1.6.0. #1601

Closed
AraHaan opened this issue May 2, 2022 · 12 comments
Closed

Update Azure.Identity to 1.6.0. #1601

AraHaan opened this issue May 2, 2022 · 12 comments

Comments

@AraHaan
Copy link
Member

AraHaan commented May 2, 2022

Azure.Identity's latest version is 1.6.0 but there is plans for some work for it to remove some more dependencies with it adding an .NET 6 TFM for it so it can require less packages which would be great for everyone using SqlClient directly or indirectly from efcore.

@JRahnama
Copy link
Contributor

JRahnama commented May 4, 2022

@AraHaan This is in our radar. We have recently updated the version, but the latest version will be used when Net6 support is added.

@AraHaan
Copy link
Member Author

AraHaan commented May 4, 2022

So I can basically add it in my PR that basically removes the needless dependencies.

Speaking of that PR, VS seems to be having issues with it as well for some reason.

@JRahnama JRahnama added this to the 5.0.0-preview3 milestone May 12, 2022
@JRahnama
Copy link
Contributor

we will do some testing and if everything works as expected we will upgrade the version in our next preview release.

@AraHaan
Copy link
Member Author

AraHaan commented May 12, 2022

I experimented with it in my pr to remove some dependencies and it compiles fine with the updated packages. I even pushed them to that PR as well.

Feel free to cherry-pick the dependency update commit from that pr if needed.

@JRahnama
Copy link
Contributor

JRahnama commented May 12, 2022

Can you make a separate PR for that. We try to avoid multiple changes in one PR to make it easier to find the source any regression? or we can do it.

Ignore my comment. I saw that is a separate PR.

@lcheunglci
Copy link
Contributor

@AraHaan already has PR #1536 opened for the Azure Identity upgrade, so I closed my PR opened earlier.

@AraHaan
Copy link
Member Author

AraHaan commented May 12, 2022

I commented on your PR. #1536 had to have the dependency updates temporarily in order to get my local build to pass.

However the updates could be moved from #1536 as they can also be used by all the other TFMs.

@DavoudEshtehari DavoudEshtehari removed this from the 5.0.0-preview3 milestone May 16, 2022
@lcheunglci
Copy link
Contributor

I added a comment in the merged PR #1611 , regarding the Microsoft.IdentityModel.* dependency i.e. upgrading from 6.8.0 to 6.18.0, where it succeeded in the netcore project but failed on netfx project because the nuget package Microsoft.IdentityModel.Abstractions doesn't exist for netfx from the solution/project's nuget repo: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json and the solution to fix it was to add the repo https://api.nuget.org/v3/index.json to it. However, I'm not sure if there was a reason behind using the azure repo vs the official nuget repo, so perhaps, one of the maintainers could chime in.

@JRahnama
Copy link
Contributor

JRahnama commented Jun 3, 2022

@lcheunglci and @AraHaan the issue with the feed should be fixed now. It is added to the public feed.

@JRahnama
Copy link
Contributor

Closing this as done in PR #1611

@AraHaan
Copy link
Member Author

AraHaan commented Jun 15, 2022

@JRahnama, @lcheunglci was the followup pr created for the other Microsoft.IdentityModel.* dependencies?

@lcheunglci
Copy link
Contributor

I have a branch with the change for the upgrade, I'll open a PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants