Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update xamarin-android to consume zlib-ng from dotnet/runtime #9082

Closed
carlossanlop opened this issue Jul 3, 2024 · 4 comments
Closed
Assignees
Labels
Area: App Runtime Issues in `libmonodroid.so`.

Comments

@carlossanlop
Copy link
Member

Android framework version

net9.0-android

Affected platform version

All

Description

The dotnet/runtime repo has migrated from consuming madler/zlib and zlib-intel to consuming zlib-ng. We merged this PR on 7/2 to achieve that: dotnet/runtime#101465

The main issue tracking this migration effort is dotnet/runtime#101465

In consequence, xamarin-macios and xamarin-android might need to make changes to ensure they retarget their dependencies appopriately.

Note: We ensured that mobile platforms find and consume the system-installed zlib, but are going to delete the zlib and zlib-intel references from the repo. So please help determine if you need to take actions on this repo.

This needs to be done before .NET 9 gets published.

Please let @carlossanlop or @akoeplinger know if you have any questions.

Steps to Reproduce

Did you find any workaround?

Relevant log output

-
@carlossanlop carlossanlop added the needs-triage Issues that need to be assigned. label Jul 3, 2024
@jpobst jpobst assigned grendello and dellis1972 and unassigned jpobst Jul 3, 2024
@jpobst jpobst added Area: App Runtime Issues in `libmonodroid.so`. and removed needs-triage Issues that need to be assigned. labels Jul 3, 2024
@dellis1972
Copy link
Contributor

@grendello LibZipSharp ises zlib-ng already doesn't it? Not sure we use it anywhere else?

@grendello
Copy link
Contributor

@dellis1972 it supports it, but we use zlib for now. There's a draft PR I need to go back to. But LibZipSharp uses its own copies of everything, due to the way it builds its support library.

I don't think we use zlib anywhere here anymore.

@jonpryor
Copy link
Member

Should we close this issue? I don't think it's relevant to us as-is.

@carlossanlop
Copy link
Member Author

Yes, I think you can close this issue and the identical one I opened for apple mobile platforms (if you all happen to be maintainers of that repo too).

Since the zlib-ng consumption in runtime is forcing the system-installed zlib to be used in mobile platforms for now (android and apple), there's no action for you to take (assuming there's any feature here that still consumes zlib).

@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: App Runtime Issues in `libmonodroid.so`.
Projects
None yet
Development

No branches or pull requests

6 participants