-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Fix remaining permanent CI warnings. #8595
Conversation
@@ -172,7 +172,7 @@ void ProcessTPN (SortedDictionary <string, ThirdPartyNotice> licenses, ThirdPart | |||
Log.StatusLine ($" {Context.Instance.Characters.Bullet} Processing: ", tpn.Name, ConsoleColor.Gray, ConsoleColor.White); | |||
|
|||
if (licenses.ContainsKey (tpn.Name)) { | |||
Log.WarningLine ($"Duplicate Third Party Notice '{tpn.Name}' (old class: {licenses [tpn.Name]}; new class: {tpn})"); | |||
Log.InfoLine ($"Duplicate Third Party Notice '{tpn.Name}' (old class: {licenses [tpn.Name]}; new class: {tpn})"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grendello does this represent some issue that we should try to fix rather than suppressing the warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention was that if we see this warning, we go in and remove the duplicate, and the assumption was that it would be a very rare occurrence. So, yep, if we see it, we should remove the license duplicates (if possible) :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning is caused by the TPN Irony
, which is used by both Xamarin.Android.Build.Tasks
and Xamarin.Android.Tools.Aidl
. I considered removing one of the instances but I was afraid that might cause us to miss the TPN in the future.
For example, we remove the Xamarin.Android.Tools.Aidl
version today. Then in the future we remove the need for Xamarin.Android.Build.Tasks
to use Irony
, so we remove that version. We would not remember that we need to add the ...Aidl
version back.
It felt safer to keep both and reduce the warning than risk accidentally removing them both in the future.
But I'm open to other suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the one question above.
Fixes various CI warnings.
Fix: only specify
major.minor
as requested.Fix: add a flag denoting that we have already imported a project and a
Condition
to prevent duplicate imports.Fix: add null check.
Fix: checking multiple URLs is part of the expected flow, downgrade message to "info".
Fix: multiple projects may use the same dependencies, downgrade to "info".
Remaining CI warnings are temporary because our MAUI tests are failing:
🎉