-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ApiScan to nightly build #8605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a link to a test build that shows successful scan output?
Edit: Ah, here it is:
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8840839&view=logs&j=37f57fd3-d289-5237-436e-59fe12c38b11&t=ea22a86e-b15b-57ea-8242-d58433d0032c
The output says:
APIscan has completed scanning and analysis.
APIscan output results indicate there are errors to resolve.
But the build is green.
Where do the results get published, and should we fail the build somehow?
Set up a new nightly test run here: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8864982&view=results |
Looks like the logging and build break step additions worked as expected, I think this should be good to merge now and we can iterate on fixing issues / adding exceptions. |
* main: [tests] fix `MAUI Integration` lane (#8614) [xaprepare] use `$(XAPackagesDir)` for NuGet folder (#8613) Add ApiScan to nightly build (#8605) Bump to dotnet/installer@29db8a1157 9.0.100-alpha.1.23628.5 (#8611) [Mono.Android] Fix ServerCertificateCustomValidator (#8594) Bump to dotnet/installer@e08874da58 9.0.100-alpha.1.23625.1 Bump to dotnet/installer@fae23c6571 9.0.100-alpha.1.23618.2 Localized file check-in by OneLocBuild Task (#8589) [tests] enable Xamarin.Android.LibraryProjectZip-LibBinding test (#8588)
Context: https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/25351/APIScan-step-by-step-guide-to-setting-up-a-Pipeline
The ApiScan task has been added to the nightly build and test run. This
task should help us identify related issues earlier, rather than having
to wait for a full scan of VS. The task can take a long time to execute
so it has been added to the nightly job rather than the PR or CI jobs.