Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binskim results for ASPNetCore contain duplicated issues #2817

Closed
andriipatsula opened this issue Aug 9, 2023 · 3 comments
Closed

Binskim results for ASPNetCore contain duplicated issues #2817

andriipatsula opened this issue Aug 9, 2023 · 3 comments
Assignees

Comments

@andriipatsula
Copy link
Member

Binskim cannot find symbols for two libraries:
• mscordaccore_amd64_amd64_#version#.dll
• mscordaccore_x86_x86_#version#.dll

As a result TSA reports duplicating work-items due to the reason that dll contains version in it's name

AspNetCoreRuntime.8.0.x64.8.0.0-rc-1-23375-5.nupkg\content\shared\Microsoft.NETCore.App\8.0.0-rc.1.23375.1\mscordaccore_amd64_amd64_8.0.23.37501.dll

Four ideas were proposed:

  1. We could exempt dlls with versions included from scanning (presuming the dll in its short form name is present and scanned as well). This seems to have two drawbacks
    a. I’m not sure if that would be possible from the compliance perspective
    b. We might miss assets with versions included in their names that wouldn’t be part of this schema
  2. Upload the long form name PDBs to the symbols server so they are found (presuming this helps with finding the pdbs)
  3. Do some custom workaround (like rename the dlls) so their pdbs are found (which seems hacky and introduces special-case complexity, so I’d like to avoid it if possible)
  4. Keep the reports as they are, with duplication

PR for the 2nd idea: dotnet/runtime#90109

@andriipatsula
Copy link
Member Author

I had a conversation with the Guardian support team.
I prepared a PR which trims the version from the TargetPath and as a results version won't affect scan results:
PR: https://dev.azure.com/dnceng/internal/_git/dotnet-release/pullrequest/33204

@andriipatsula
Copy link
Member Author

Examined the latest results, and they appear good with no instances of duplicated work-items. Communicated with the ASPNetCore team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant