Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable creation of batchable source-enabled backflow subscriptions #4359

Closed
2 tasks
premun opened this issue Jan 22, 2025 · 2 comments
Closed
2 tasks

Disable creation of batchable source-enabled backflow subscriptions #4359

premun opened this issue Jan 22, 2025 · 2 comments
Assignees

Comments

@premun
Copy link
Member

premun commented Jan 22, 2025

Context

In #3378, we added a support for batchable subscriptions.
These only make sense in forward-flow scenarios though. For backflow, it would have to mean there's a subscription to multiple VMRs. This does not make much sense but the tooling (darc, the API) still technically allow creation of the subscriptions. We should forbid this.

Goal

  • Make darc error out when a user tries to add/update a subscription and make it batchable + source enabled + backflow (meaning the source directory is set).
  • Make the API return 400 when the same happens and someone tries to create a batchable source enabled backflow subscription.
@premun premun changed the title Disable creation of source-enabled backflow subscriptions Disable creation of batchable source-enabled backflow subscriptions Jan 22, 2025
@adamzip
Copy link
Contributor

adamzip commented Jan 23, 2025

On top of forbidding the creation of a source-enabled batched subscription, would it make sense to disallow repos from having more than one source-enabled subscription? (this implies subscription to multiple VMRs too, right?)

@premun
Copy link
Member Author

premun commented Jan 29, 2025

Done, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants