Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test known issue not displayed #10537

Closed
net-helix bot opened this issue Aug 22, 2022 · 9 comments
Closed

Test known issue not displayed #10537

net-helix bot opened this issue Aug 22, 2022 · 9 comments
Assignees
Labels
Sentiment Feedback This issue is directly from user feedback from the sentiment tracking feature

Comments

@net-helix
Copy link

net-helix bot commented Aug 22, 2022

A negative sentiment was registered against feature: DeveloperWorkflowGitHubCheckTab

Failure undetected - It's a known issue as of 12 days ago: dotnet/runtime#73688; I know it's hard since it's a whole workitem failure and not just a test. Likely needs business logic for it to be actionable, like helix log search.

Feedback submitted by @hoyosjs, who requested further communication regarding this issue.

Parameters

c = ab5bf51d79fc
rb = 0
rt = 0
ub = 0
e = 0
r = dotnet/runtime
s = 2022-08-22T13-22-18
ki = 0
ut = 1

@net-helix net-helix bot added the Sentiment Feedback This issue is directly from user feedback from the sentiment tracking feature label Aug 22, 2022
@missymessa missymessa changed the title Sentiment Tracking #3389 Known issue not detected Aug 22, 2022
@missymessa
Copy link
Member

@ulisesh thinking that the known issue isn't being picked up because the error is in the work item logs? (I haven't investigated Juan's issue, however)

@hoyosjs
Copy link
Member

hoyosjs commented Aug 22, 2022

Sorry - I am not saying there's an issue with the JSON + Tag. That wouldn't work as you said. However, the issue has been seen in other PRs within a few days - it's just not easy to identify since it's a whole workitem crash.

@ulisesh
Copy link
Contributor

ulisesh commented Aug 22, 2022

Now that we have support for known issues for tests build analysis should be able to identify this error.

A known issues with the correct label and the error string like StreamShutdown failed: QUIC_STATUS_INVALID_PARAMETER should be enough. @hoyosjs we are very interested in seeing this working as we just release the feature. If the error string make sense, can you please update your issue with the label and JSON blob?

@hoyosjs
Copy link
Member

hoyosjs commented Aug 22, 2022

Oh, I know it was stages to roll out but didn't know it was out in the wild. Will do. Thanks!

@hoyosjs
Copy link
Member

hoyosjs commented Aug 23, 2022

@ulisesh can you please check if I did somehting wrong: dotnet/runtime#73688

@ulisesh
Copy link
Contributor

ulisesh commented Aug 23, 2022

The issue has everything it needs, I'll check why build analysis isn't finding any hits

@ulisesh
Copy link
Contributor

ulisesh commented Aug 23, 2022

Turns out that there is a bug in build analysis that prevents test known issues from being displayed, I'll fix it but unfortunately the fix will be roll out next Wednesday. FYI, this is how we were expecting the known issue to be showed https://gist.github.com/ulisesh/1b616e4188ef0af87b05fe7e1e99c989

@hoyosjs, thanks for working with us

@ulisesh ulisesh changed the title Known issue not detected Test known issue not displayed Aug 23, 2022
@ulisesh
Copy link
Contributor

ulisesh commented Aug 23, 2022

PR: https://dev.azure.com/dnceng/internal/_git/dotnet-helix-service/pullrequest/25240

@ulisesh
Copy link
Contributor

ulisesh commented Sep 13, 2022

Rolled out

@ulisesh ulisesh closed this as completed Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sentiment Feedback This issue is directly from user feedback from the sentiment tracking feature
Projects
None yet
Development

No branches or pull requests

3 participants