Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'IsWpfTempProject' workaround after .NET Core Preview 8 is released #3129

Closed
ryalanms opened this issue Jun 21, 2019 · 5 comments
Closed
Assignees

Comments

@ryalanms
Copy link
Member

WPF for .NET Core is adding PackageReference restore to temporary project compilation in Preview 8. When Preview 8 is released, the existing workaround needs to be removed from Arcade.

https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/tools/Workarounds.props#L5
https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/tools/Workarounds.targets#L26

@vatsan-madhavan
Copy link
Member

We should have a tracking issue in wpf repo as well so it gets triaged and prioritized for P8.

@ryalanms
Copy link
Member Author

@vatsan-madhavan: I've opened issue dotnet/wpf#1055 in the WPF repo. Thanks.

@tmat
Copy link
Member

tmat commented Jun 21, 2019

We can't remove the workaround since we are not using Core WPF in most repos, but .NET Framework WPF. We can condition the workaround on TFM though.

@vatsan-madhavan
Copy link
Member

Makes sense. In the next PR, use condition to detect WindowsDesktop Sdk (see dotnet/wpf#1027 - there is a property you can sniff).

@markwilkie
Copy link
Member

Seems this is resolved. Pls reopen if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants