-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'IsWpfTempProject' workaround after .NET Core Preview 8 is released #3129
Comments
We should have a tracking issue in wpf repo as well so it gets triaged and prioritized for P8. |
@vatsan-madhavan: I've opened issue dotnet/wpf#1055 in the WPF repo. Thanks. |
We can't remove the workaround since we are not using Core WPF in most repos, but .NET Framework WPF. We can condition the workaround on TFM though. |
Makes sense. In the next PR, use condition to detect WindowsDesktop Sdk (see dotnet/wpf#1027 - there is a property you can sniff). |
Seems this is resolved. Pls reopen if not. |
WPF for .NET Core is adding PackageReference restore to temporary project compilation in Preview 8. When Preview 8 is released, the existing workaround needs to be removed from Arcade.
https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/tools/Workarounds.props#L5
https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/tools/Workarounds.targets#L26
The text was updated successfully, but these errors were encountered: