Reorganize the installer targets to provide a better/cleaner UX and integrate better with the SharedFX SDK #15239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rties to only be available in the "single installer build" nested build phase (which is where the target that provided them was executed)
…x package layout msbuild goo. Provide common owned directories directly from the shared framework SDK instead of requiring every consumer to specify them all explicitly.
jkoritzinsky
requested review from
NikolaMilosavljevic,
ViktorHofer and
akoeplinger
akoeplinger
approved these changes
Nov 12, 2024
| @@ -0,0 +1,20 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <TargetRuntimeOS>$(InstallerRuntimeIdentifier.Substring(0, $(InstallerRuntimeIdentifier.LastIndexOf('-'))))</TargetRuntimeOS> | |||
There was a problem hiding this comment.
nit: I'd prefer if we don't invent a new property here that is only used by the installer targets when we already have many other similar properties. I know this is preexisting so feel free to address later.
There was a problem hiding this comment.
I'll address this in a future PR.
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move many installer properties out of targets and refactor most properties to only be available in the "single installer build" nested build phase (which is where the target that provided them was executed).
Improvements can be seen in dotnet/runtime#109710
To double check: