From 98950280f176b5908fc985fe441d9d7a6ae84ae7 Mon Sep 17 00:00:00 2001 From: Eric Erhardt Date: Fri, 23 Feb 2024 13:58:51 -0600 Subject: [PATCH] Fix ServiceBus endpoint logic (#2385) In previous versions of the ServiceBus SDK, it didn't accept `https://` URIs as the fully qualified namespace, but the ResourceManager APIs only return URIs with `https://`. So we had logic in our bicep template to remove the https. However, this doesn't work with the runtime component because it expected sb://. The fix is to update to the latest ServiceBus version, which accepts https:// for the namespace URI. And also remove our bicp logic to just pass the endpoint through unmodified. Also clean up the Directory.Packages.props file. Fix #2378 --- Directory.Packages.props | 21 ++++++------------- .../Bicep/servicebus.bicep | 2 +- 2 files changed, 7 insertions(+), 16 deletions(-) diff --git a/Directory.Packages.props b/Directory.Packages.props index 4633a31b98..c1070fe622 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -6,28 +6,19 @@ - + - - - + + - - + - - - - - - - - - + + diff --git a/src/Aspire.Hosting.Azure/Bicep/servicebus.bicep b/src/Aspire.Hosting.Azure/Bicep/servicebus.bicep index ba6f936f1f..89795d830c 100644 --- a/src/Aspire.Hosting.Azure/Bicep/servicebus.bicep +++ b/src/Aspire.Hosting.Azure/Bicep/servicebus.bicep @@ -51,4 +51,4 @@ resource ServiceBusRoleAssignment 'Microsoft.Authorization/roleAssignments@2022- } } -output serviceBusEndpoint string = replace(serviceBusNamespace.properties.serviceBusEndpoint, 'https://', '') +output serviceBusEndpoint string = serviceBusNamespace.properties.serviceBusEndpoint