Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to reconnect modal should not be an overlay? #2514

Closed
premun opened this issue Feb 28, 2024 · 4 comments · Fixed by #3189
Closed

Attempting to reconnect modal should not be an overlay? #2514

premun opened this issue Feb 28, 2024 · 4 comments · Fixed by #3189
Assignees

Comments

@premun
Copy link
Member

premun commented Feb 28, 2024

When working locally and watching logs from a server, if the server/process dies or is stopped, there still might be valuable debugging information in the logs that I would like to read/copy even after the server is stopped.

The reconnect overlay makes reading these hard, copying not possible. It could very well be some modal dialog element that doesn't block the page this way and improve the UX.

image

@davidfowl
Copy link
Member

@kvenkatrajan I think we should do this in preview 5, it's a long standing annoying work item.

@SteveSandersonMS is there anything we should know WRT blazor to make this reconnet experience a bit better? Background retries making it possible to navigate would be great but that likely requires more work (and client state?).

@SteveSandersonMS
Copy link
Member

@davidfowl We're tracking the general need to improve the reconnection experience at dotnet/aspnetcore#32113.

We've prototyped a possible improved UX at https://github.com/SteveSandersonMS/StatefulReconnection. If you're interested in trying that out in the Aspire dashboard, we'd definitely appreciate any feedback on it. Of course, we're open to other suggestions too.

As for the default reconnection modal making things unselectable, this is something that Blazor developers can control, replacing it with any HTML/CSS: https://learn.microsoft.com/en-us/aspnet/core/blazor/fundamentals/signalr?view=aspnetcore-3.1#reflect-the-server-side-connection-state-in-the-ui

@adamint
Copy link
Member

adamint commented Mar 26, 2024

@SteveSandersonMS unfortunately it doesn't look like that UX meets our needs, as it still appears as a modal

@SteveSandersonMS
Copy link
Member

@adamint You can customize the overlay not to be a modal, as that's only controlled by CSS. This is true both for the existing built-in reconnection UI and the StatefulReconnection prototype.

However you will have to make more complicated UX decisions if you do that, since all interactivity in your UI will not operate if there's no connection, and it will be confusing to users if they can't anticipate which parts of the UI work and don't work.

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants